Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[filebeat] Add E2E testing for filebeat in otel mode #42226

Merged
merged 15 commits into from
Jan 9, 2025

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Jan 7, 2025

Proposed commit message

This adds. E2E test for filebeat in otel mode and confirms all the log records are indexed.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd x-pack/filebeat
mage build
mage docker:composeUp
go test -run TestFilebeatOTelE2E -tags integration ./tests/integration

Related issues

Related to https://github.com/elastic/ingest-dev/issues/4595

@khushijain21 khushijain21 requested review from a team as code owners January 7, 2025 05:42
@khushijain21 khushijain21 requested review from faec and leehinman January 7, 2025 05:42
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 7, 2025
Copy link
Contributor

mergify bot commented Jan 7, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 7, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 7, 2025
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jan 7, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 7, 2025
@khushijain21 khushijain21 requested review from rdner and mauri870 January 8, 2025 06:19
rdner
rdner previously approved these changes Jan 8, 2025
@rdner rdner dismissed their stale review January 8, 2025 18:58

Found an issue with the test that we should either address in this PR or agree on a follow up.

@khushijain21 khushijain21 requested a review from rdner January 9, 2025 05:00
@khushijain21 khushijain21 requested a review from mauri870 January 9, 2025 10:41
@khushijain21 khushijain21 enabled auto-merge (squash) January 9, 2025 12:37
@khushijain21 khushijain21 merged commit e22f933 into elastic:main Jan 9, 2025
141 checks passed
mergify bot pushed a commit that referenced this pull request Jan 9, 2025
* [filebeat] Add E2E testing for filebeat in otel mode

- Add E2E test for filebeat and elasticsearch

Co-authored-by: Denis <denis@rdner.de>

* use v8 es version

* check for existence of events

---------

Co-authored-by: Denis <denis@rdner.de>
(cherry picked from commit e22f933)
khushijain21 added a commit that referenced this pull request Jan 9, 2025
* [filebeat] Add E2E testing for filebeat in otel mode

- Add E2E test for filebeat and elasticsearch

Co-authored-by: Denis <denis@rdner.de>

* use v8 es version

* check for existence of events

---------

Co-authored-by: Denis <denis@rdner.de>
(cherry picked from commit e22f933)

Co-authored-by: Khushi Jain <khushi.jain@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants