Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.17](backport #42225) [filebeat][websocket] - Added infinite & blanket retry options to websockets and improved logging and retry logic #42236

Merged
merged 2 commits into from
Jan 7, 2025
Merged

[8.17](backport #42225) [filebeat][websocket] - Added infinite & blanket retry options to websockets and improved logging and retry logic #42236

merged 2 commits into from
Jan 7, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 7, 2025

Type of change

  • Enhancement
  • Docs

Proposed commit message

Added new config options to enable blanket & infinite retries selectively. There might be edge case scenarios in production environments which might require to retry infinitely (with backoff) in all scenarios. These options can be individually controlled and are not coupled together. Also improved logging for the retry section.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

This is an automatic backport of pull request #42225 done by [Mergify](https://mergify.com).

@ShourieG @mergify
[filebeat][websocket] - Added infinite & blanket retry options to web…
a21e029 
…sockets and improved logging and retry logic (#42225)

* added blanket & infinite retry options and improved logging

(cherry picked from commit 177a47a)
@mergify mergify bot added the backport label Jan 7, 2025
@mergify mergify bot requested a review from a team as a code owner January 7, 2025 12:10
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 7, 2025
@botelastic
Copy link

botelastic bot commented Jan 7, 2025

This pull request doesn't have a Team:<team> label.

@ShourieG ShourieG merged commit 2349011 into 8.17 Jan 7, 2025
20 of 22 checks passed
@ShourieG ShourieG deleted the mergify/bp/8.17/pr-42225 branch January 7, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@ShourieG ShourieG

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ShourieG