Move prospector log to its own package #4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
Filebeat
filebeat/prospector/prospector.go
Outdated
| default: | ||
| return fmt.Errorf("Invalid input type: %v", p.config.InputType) | ||
| return fmt.Errorf("Invalid prospector type: %v. Change input_type.", p.config.InputType) |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
error strings should not be capitalized or end with punctuation or a newline
| @@ -509,3 +511,16 @@ func (l *Log) updateState(state file.State) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func (p *Prospector) Wait() { | |||
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method Prospector.Wait should have comment or be unexported
| p.Stop() | ||
| } | ||
|
|
||
| func (p *Prospector) Stop() { |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method Prospector.Stop should have comment or be unexported
| state, | ||
| nil, | ||
| outlet, | ||
| ) | ||
|
|
||
| return h, err | ||
| } | ||
|
|
||
| func (p *Prospector) Wait() {} |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method Prospector.Wait should have comment or be unexported
| state, | ||
| nil, | ||
| outlet, | ||
| ) | ||
|
|
||
| return h, err | ||
| } | ||
|
|
||
| func (p *Prospector) Wait() {} | ||
| func (p *Prospector) Stop() {} |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method Prospector.Stop should have comment or be unexported
ruflin
force-pushed
the
log-prospector-package
branch
3 times, most recently
from
78335f9 to
1e9e26c
Compare
ruflin
added
review
and removed
in progress
14 tasks
ruflin
force-pushed
the
log-prospector-package
branch
from
1e9e26c to
3255a7c
Compare
|
jenkins, retest it |
7AC
suggested changes
May 10, 2017
| @@ -18,7 +18,7 @@ import ( | |||
|
|
|||
| "github.com/satori/go.uuid" | |||
|
|
|||
| "github.com/elastic/beats/filebeat/config" | |||
| cfg "github.com/elastic/beats/filebeat/config" | |||
ruflin
force-pushed
the
log-prospector-package
branch
from
3255a7c to
c4b0d62
Compare
7AC
approved these changes
May 10, 2017
filebeat/prospector/prospector.go
Outdated
| default: | ||
| return fmt.Errorf("Invalid input type: %v", p.config.InputType) | ||
| return fmt.Errorf("invalid prospector type: %v. Change input_type.", p.config.InputType) |
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
error strings should not be capitalized or end with punctuation or a newline
This is the last step in reorganising the packages related to prospector and harvester. Follow up PR's will mainly focusing on abstracting out common functionality, standardise naming and have proper interfaces. * Merge log harvester and log prospector config into one config * Rename Log to prospector as part of the new package structure * Move log harvester logic to log prospector package * Keep common harvester logic in its own package * stdin harvester still heavily depends on log harvester, needs to be split up and simplified at a later stage * Further cleanup of Prospector interface. `Wait()` only exists as a temporary solution.
ruflin
force-pushed
the
log-prospector-package
branch
from
c4b0d62 to
676e836
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last step in reorganising the packages related to prospector and harvester. Follow up PR's will mainly focusing on abstracting out common functionality, standardise naming and have proper interfaces.
Wait()only exists as a temporary solution.