Allow string characters in user agent patch version #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exekias
force-pushed
the
allow-browser-patch-strings
branch
from
8a689d5
to
26bbcb4
Compare
exekias
changed the title
exekias
force-pushed
the
allow-browser-patch-strings
branch
from
26bbcb4
to
9252cfd
Compare
Both for NGINX and Apache logs
exekias
force-pushed
the
allow-browser-patch-strings
branch
from
9252cfd
to
a10c1b7
Compare
|
kubelet metricsets failed again here, tests are flaky, I have to look into that |
tsg
added
needs_backport
tsg
approved these changes
May 29, 2017
exekias
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both for NGINX and Apache logs
Fixes #3836
This changes the mapping, what's our policy for these cases?