Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented May 23, 2025

Proposed commit message

For beat receivers move when the HTTP endpoint is started to before when the beater is created. This makes it like
normal" beats and will start the "stats" and "inputs" endpoints.

This does have duplication between mbreceiver and fbreceiver, we can refactor that back into beatreceiver package when we refactor the location of the beatreceiver package.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None. Beats receivers not GA and this add "inputs" endpoint that was missing

Author's Checklist

  • [ ]

How to test this PR locally

Filebeat

cd x-pack/filebeat/fbreceiver
go test .

Metricbeat

cd x-pack/metricbeat/mbreceiver
go test .

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #44438 done by [Mergify](https://mergify.com).

* [beat_receivers] move when monitoring is started

(cherry picked from commit 82f47f7)
@mergify mergify bot added the backport label May 23, 2025
@mergify mergify bot requested a review from a team as a code owner May 23, 2025 22:19
@mergify mergify bot requested review from belimawr and khushijain21 and removed request for a team May 23, 2025 22:19
@mergify mergify bot added the backport label May 23, 2025
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 23, 2025
@github-actions github-actions bot added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team bugfix labels May 23, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 23, 2025
@mergify
Copy link
Contributor Author

mergify bot commented May 26, 2025

This pull request has not been merged yet. Could you please review and merge it @leehinman? 🙏

1 similar comment
@mergify
Copy link
Contributor Author

mergify bot commented Jun 2, 2025

This pull request has not been merged yet. Could you please review and merge it @leehinman? 🙏

@pierrehilbert
Copy link
Contributor

@leehinman could you please resolve the conflicts?

#43356 was not backported
@mergify
Copy link
Contributor Author

mergify bot commented Jun 4, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.19/pr-44438 upstream/mergify/bp/8.19/pr-44438
git merge upstream/8.19
git push upstream mergify/bp/8.19/pr-44438

@leehinman
Copy link
Contributor

Closing because without #43356 being backported we won't have individual logging under multiple receivers.

@leehinman leehinman closed this Jun 4, 2025
@mergify mergify bot deleted the mergify/bp/8.19/pr-44438 branch June 4, 2025 20:47
@leehinman leehinman restored the mergify/bp/8.19/pr-44438 branch June 23, 2025 16:17
@leehinman leehinman reopened this Jun 23, 2025
@mergify
Copy link
Contributor Author

mergify bot commented Jun 23, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.19/pr-44438 upstream/mergify/bp/8.19/pr-44438
git merge upstream/8.19
git push upstream mergify/bp/8.19/pr-44438

@pierrehilbert pierrehilbert merged commit 93f6d9d into 8.19 Jun 24, 2025
61 checks passed
@pierrehilbert pierrehilbert deleted the mergify/bp/8.19/pr-44438 branch June 24, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport bugfix Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants