Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packetbeat: add PID to the list of exported fields #4487

Closed
wants to merge 2 commits into from
Closed

Packetbeat: add PID to the list of exported fields #4487

wants to merge 2 commits into from

Conversation

tsg
Copy link
Contributor

@tsg tsg commented Jun 9, 2017 •
edited by monicasarbu
Loading

We had the process names, and this adds also the PID, closing #562.

Diff is quite long due to existing code repetition between modules. This also gets rid of some unnecessary type casts.

Todo:

  • figure out a way to test this
  • changelog

Tudor Golubenco added 2 commits June 9, 2017 23:38
Packetbeat: add PID to the list of exported fields
5faec69 
We had the process names, and this adds also the PID, closing elastic#562.
Document new field
b5288f3
@tsg tsg added in progress Pull request is currently in progress. Packetbeat review labels Jun 9, 2017
@tsg tsg changed the title Add packetbeat pid Packetbeat: add PID to the list of exported fields Jun 9, 2017
@tsg
Copy link
Contributor Author

tsg commented Jan 30, 2019

This got stalled and it's too old now.

@tsg tsg closed this Jan 30, 2019
@andrewkroh
Copy link
Member

Packetbeat now has client.process.pid and server.process.pid as of #9303.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
in progress Pull request is currently in progress. Packetbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsg @andrewkroh