Remove empty properties from the template files #4488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
force-pushed
the
remove_empty_properties
branch
from
a042bb5
to
ace958a
Compare
This were introduced in elastic#3515, but I think they cause issues like the one in elastic#4483, at least in recent versions of ES. We already removed these in master, but I didn't realize the 5.x branches are affected. Fixes elastic#4483.
tsg
force-pushed
the
remove_empty_properties
branch
from
ace958a
to
a373306
Compare
monicasarbu
pushed a commit
that referenced
this pull request
Jun 14, 2017
…iles (#4498) * Remove empty properties from the template files This were introduced in #3515, but I think they cause issues like the one in #4483, at least in recent versions of ES. We already removed these in master, but I didn't realize the 5.x branches are affected. Fixes #4483. (cherry picked from commit a373306) * update testing env
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…plate files (elastic#4498) * Remove empty properties from the template files This were introduced in elastic#3515, but I think they cause issues like the one in elastic#4483, at least in recent versions of ES. We already removed these in master, but I didn't realize the 5.x branches are affected. Fixes elastic#4483. (cherry picked from commit d9fc986) * update testing env
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This were introduced in #3515, but I think they cause issues like
the one in #4483, at least in recent versions of ES.
We already removed these in master, but I didn't
realize the 5.x branches are affected.
Fixes #4483.