Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to auditbeat file metricset #4796

Merged

Conversation

andrewkroh
Copy link
Member

  • Modify file.paths to be a list instead of a dictionary.
  • Added file.hash_types config option for controlling the hash types.
  • Added new hash types.
  • Fixed file.max_file_size config option. It was missing the "file." prefix when reading the option.
  • Added the ability to specify byte unit suffixes to file.max_file_size.
  • Added documentation for the audit file metricset.

@andrewkroh andrewkroh added Auditbeat docs needs_backport PR is waiting to be backported to other branches. labels Jul 31, 2017
@andrewkroh andrewkroh force-pushed the feature/ab/file-metricset-updates branch 2 times, most recently from 26a1cda to b2a831a Compare July 31, 2017 16:08
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please rebase?

Modify `file.paths` to be a list instead of a dictionary.
Added `file.hash_types` config option for controlling the hash types.
Added new hash types.
Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option.
Added the ability to specify byte unit suffixes to `file.max_file_size`.
Added documentation for the audit file metricset.
@andrewkroh andrewkroh force-pushed the feature/ab/file-metricset-updates branch from b2a831a to 2c67861 Compare August 1, 2017 12:16
@andrewkroh
Copy link
Member Author

I rebased it.

@exekias exekias merged commit 07170c6 into elastic:master Aug 1, 2017
@andrewkroh andrewkroh removed the needs_backport PR is waiting to be backported to other branches. label Aug 1, 2017
andrewkroh added a commit to andrewkroh/beats that referenced this pull request Aug 1, 2017
Modify `file.paths` to be a list instead of a dictionary.
Added `file.hash_types` config option for controlling the hash types.
Added new hash types.
Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option.
Added the ability to specify byte unit suffixes to `file.max_file_size`.
Added documentation for the audit file metricset.
(cherry picked from commit 07170c6)
tsg pushed a commit that referenced this pull request Aug 2, 2017
…4807)

* Enhancements to auditbeat file metricset (#4796)

Modify `file.paths` to be a list instead of a dictionary.
Added `file.hash_types` config option for controlling the hash types.
Added new hash types.
Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option.
Added the ability to specify byte unit suffixes to `file.max_file_size`.
Added documentation for the audit file metricset.
(cherry picked from commit 07170c6)

* Update test to use named field in composite literal

Fixes a `go vet` warning.

    module/audit/kernel/audit_linux_test.go:31: github.com/elastic/beats/vendor/github.com/elastic/go-libaudit.AuditClient composite literal uses unkeyed fields
@andrewkroh andrewkroh deleted the feature/ab/file-metricset-updates branch January 17, 2018 16:46
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…cset (elastic#4807)

* Enhancements to auditbeat file metricset (elastic#4796)

Modify `file.paths` to be a list instead of a dictionary.
Added `file.hash_types` config option for controlling the hash types.
Added new hash types.
Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option.
Added the ability to specify byte unit suffixes to `file.max_file_size`.
Added documentation for the audit file metricset.
(cherry picked from commit 7b020cc)

* Update test to use named field in composite literal

Fixes a `go vet` warning.

    module/audit/kernel/audit_linux_test.go:31: github.com/elastic/beats/vendor/github.com/elastic/go-libaudit.AuditClient composite literal uses unkeyed fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants