-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to auditbeat file metricset #4796
Merged
exekias
merged 1 commit into
elastic:master
from
andrewkroh:feature/ab/file-metricset-updates
Aug 1, 2017
Merged
Enhancements to auditbeat file metricset #4796
exekias
merged 1 commit into
elastic:master
from
andrewkroh:feature/ab/file-metricset-updates
Aug 1, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
added
Auditbeat
docs
needs_backport
PR is waiting to be backported to other branches.
labels
Jul 31, 2017
andrewkroh
force-pushed
the
feature/ab/file-metricset-updates
branch
2 times, most recently
from
July 31, 2017 16:08
26a1cda
to
b2a831a
Compare
exekias
approved these changes
Aug 1, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, can you please rebase?
Modify `file.paths` to be a list instead of a dictionary. Added `file.hash_types` config option for controlling the hash types. Added new hash types. Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option. Added the ability to specify byte unit suffixes to `file.max_file_size`. Added documentation for the audit file metricset.
andrewkroh
force-pushed
the
feature/ab/file-metricset-updates
branch
from
August 1, 2017 12:16
b2a831a
to
2c67861
Compare
I rebased it. |
andrewkroh
removed
the
needs_backport
PR is waiting to be backported to other branches.
label
Aug 1, 2017
andrewkroh
added a commit
to andrewkroh/beats
that referenced
this pull request
Aug 1, 2017
Modify `file.paths` to be a list instead of a dictionary. Added `file.hash_types` config option for controlling the hash types. Added new hash types. Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option. Added the ability to specify byte unit suffixes to `file.max_file_size`. Added documentation for the audit file metricset. (cherry picked from commit 07170c6)
tsg
pushed a commit
that referenced
this pull request
Aug 2, 2017
…4807) * Enhancements to auditbeat file metricset (#4796) Modify `file.paths` to be a list instead of a dictionary. Added `file.hash_types` config option for controlling the hash types. Added new hash types. Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option. Added the ability to specify byte unit suffixes to `file.max_file_size`. Added documentation for the audit file metricset. (cherry picked from commit 07170c6) * Update test to use named field in composite literal Fixes a `go vet` warning. module/audit/kernel/audit_linux_test.go:31: github.com/elastic/beats/vendor/github.com/elastic/go-libaudit.AuditClient composite literal uses unkeyed fields
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…cset (elastic#4807) * Enhancements to auditbeat file metricset (elastic#4796) Modify `file.paths` to be a list instead of a dictionary. Added `file.hash_types` config option for controlling the hash types. Added new hash types. Fixed `file.max_file_size` config option. It was missing the "file." prefix when reading the option. Added the ability to specify byte unit suffixes to `file.max_file_size`. Added documentation for the audit file metricset. (cherry picked from commit 7b020cc) * Update test to use named field in composite literal Fixes a `go vet` warning. module/audit/kernel/audit_linux_test.go:31: github.com/elastic/beats/vendor/github.com/elastic/go-libaudit.AuditClient composite literal uses unkeyed fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file.paths
to be a list instead of a dictionary.file.hash_types
config option for controlling the hash types.file.max_file_size
config option. It was missing the "file." prefix when reading the option.file.max_file_size
.