Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add SetValue method to libbeat common.MapStr (#4838)" #4868

Merged
merged 1 commit into from
Aug 10, 2017
Merged

Revert "Add SetValue method to libbeat common.MapStr (#4838)" #4868

merged 1 commit into from
Aug 10, 2017

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Aug 10, 2017

This reverts commit fa77316.

@simitt simitt requested review from ruflin and andrewkroh August 10, 2017 15:19
@simitt simitt added the review label Aug 10, 2017
andrewkroh
andrewkroh approved these changes Aug 10, 2017
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For anyone following along, see the discussion here.

@andrewkroh andrewkroh merged commit 92ac985 into elastic:master Aug 10, 2017
@simitt simitt deleted the fix/revert_commit branch September 29, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@ruflin ruflin Awaiting requested review from ruflin

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simitt @andrewkroh