Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set value 'dynamic' for groups. #4894

Merged
merged 1 commit into from
Aug 14, 2017
Merged

Set value 'dynamic' for groups. #4894

merged 1 commit into from
Aug 14, 2017

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Aug 14, 2017

I haven't seen any tests for the process method so I just added this little fix and tested it manually.

@simitt simitt requested a review from ruflin August 14, 2017 15:18
@simitt simitt mentioned this pull request Aug 14, 2017
Merged
ruflin
ruflin approved these changes Aug 14, 2017
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should definitively add tests for this in the future as the missing tests are probably the reason this slipped through :-(

@ruflin
Copy link
Contributor

ruflin commented Aug 14, 2017

jenkins, test it

@ruflin
Copy link
Contributor

ruflin commented Aug 14, 2017

Merging as test failures are unrelated.

@ruflin ruflin merged commit a7103d1 into elastic:master Aug 14, 2017
@simitt simitt mentioned this pull request Aug 15, 2017
Closed
@simitt simitt deleted the fix/add_dynamic_for_groups branch September 29, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
libbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simitt @ruflin