Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set array type to ObjectType of field if available. #4896

Merged
merged 1 commit into from
Aug 14, 2017

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Aug 14, 2017

Type of array items needs to be defined when creating a mapping for arrays. For dynamic mapping ES uses the type of the first array item. For pre-defined mapping use ObjectType information set in the fields.yml if available.

Type of array items needs to be defined when creating a mapping for arrays. For dynamic mapping ES uses the type of the first array item. For pre-defined mapping use ObjectType information set in the fields.yml if available.
@ruflin
Copy link
Contributor

ruflin commented Aug 14, 2017

jenkins, test it

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Thanks for fixing it and even adding tests.

@ruflin
Copy link
Contributor

ruflin commented Aug 14, 2017

Merging as build failures are unrelated.

@ruflin ruflin merged commit d1263b9 into elastic:master Aug 14, 2017
@simitt simitt deleted the fix/array_add_type branch September 29, 2017 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants