Fix PostgreSQL dashboards #4905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
reviewed
Aug 16, 2017
| @@ -6,13 +6,13 @@ | |||
| "kibanaSavedObjectMeta": { | |||
| "searchSourceJSON": "{\"filter\":[]}" | |||
| }, | |||
| "savedSearchId": "ef9da9b0-776c-11e7-9e03-393c0d1aa325", | |||
| "savedSearchId": "PostgreSQL All Logs", | |||
There was a problem hiding this comment.
Just for my understanding, were the changes in the vis and searches IDs also necessary? Or would have the index pattern change be enough, and this is only for consistency?
There was a problem hiding this comment.
Index pattern change was not enough. It was necessary to change the ids otherwise searches and visualizations couldn't be located. Also, I checked the working dashboards and those JSONs contain similar IDs. I wanted to be consistent with the existing correct dashboard JSONs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously broken dashboards are fixed by using names as ids.