Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .go files style to editorconfig #5236

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Add .go files style to editorconfig #5236

merged 1 commit into from
Sep 25, 2017

Conversation

pgilad
Copy link
Contributor

@pgilad pgilad commented Sep 25, 2017

No description provided.

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@ruflin
Copy link
Contributor

ruflin commented Sep 25, 2017

We didn't have it in this in the .editorconfig so far as we format all the .go files with goimports. I'm not sure how goimports and editorconfig will compete on the formatting even though I think 4 tabs should be correct normally.

@pgilad
Copy link
Contributor Author

pgilad commented Sep 25, 2017

I use vim with editorconfig plugin for editing, so currently it had no idea that the project uses tabs for go files (there is no default). I guess this could be the same for IntelliJ and the rest of those bunch. Anyway if the project defines a clear style for .go files, it is a standard to add it to editorconfig as well

@ruflin
Copy link
Contributor

ruflin commented Sep 25, 2017

We use the Golang standard: https://blog.golang.org/go-fmt-your-code I don't know if this could be reproduced with .editorconfig? It does much more then just indentations.

@pgilad
Copy link
Contributor Author

pgilad commented Sep 25, 2017

I'm not a golang pro, but I don't think that declaring .go files with tabs will ruin it ;)

@ruflin ruflin merged commit f61ecc3 into elastic:master Sep 25, 2017
@ruflin
Copy link
Contributor

ruflin commented Sep 25, 2017

Best option to figure out is merging and see what happens.

@pgilad pgilad deleted the feature/add-go-to-editor-config branch September 25, 2017 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants