Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OutputPrecision in kibana-index-generation script. #5318

Merged
merged 1 commit into from
Oct 4, 2017
Merged

Fix OutputPrecision in kibana-index-generation script. #5318

merged 1 commit into from
Oct 4, 2017

Conversation

simitt
Copy link
Contributor

@simitt simitt commented Oct 4, 2017 •
edited
Loading

The current implementation treats the OutputPrecision as a String, but it actually should be an Integer. This is a bugfix for that.

@simitt simitt added the review label Oct 4, 2017
@simitt simitt requested a review from ruflin October 4, 2017 09:30
ruflin
ruflin approved these changes Oct 4, 2017
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@simitt Could you add a note to the PR description on what is not working with the current implementation?

@simitt simitt mentioned this pull request Oct 4, 2017
Merged
@simitt
Copy link
Contributor Author

simitt commented Oct 4, 2017

@ruflin failing test does not seem to be related.

@ruflin ruflin merged commit 4cb8714 into elastic:master Oct 4, 2017
@simitt simitt deleted the fix-kibana-index-pattern branch April 12, 2018 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simitt @ruflin