Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to gosigar v0.5.0 #5385

Merged
merged 1 commit into from
Oct 12, 2017
Merged

Conversation

ph
Copy link
Contributor

@ph ph commented Oct 12, 2017

Update gosigar to make the code more robust when we cannot fetch all information for a MacOS X
process.

Closes: #5337

Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you add an entry to the beats CHANGELOG file. I guess it would be a bugfix for metricbeat.

@ph
Copy link
Contributor Author

ph commented Oct 12, 2017

I think I am gonna add that check (changelog) to my pre commit hook.

@ph ph force-pushed the fix/update-gosigar-v0.5.0 branch from f59a9ab to e156c5d Compare October 12, 2017 15:57
@ph
Copy link
Contributor Author

ph commented Oct 12, 2017

@andrewkroh updated

@ph
Copy link
Contributor Author

ph commented Oct 12, 2017

will update the notice txt..

Update gosigar to make the code more robust when we cannot fetch all information for a MacOS X
process.

Closes: elastic#5337
@ph ph force-pushed the fix/update-gosigar-v0.5.0 branch from e156c5d to b20fa91 Compare October 12, 2017 16:11
@andrewkroh andrewkroh merged commit d7b4d4f into elastic:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants