Fix double @timestamp key when using JSON decoding #5436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsg
added
bug
Filebeat
4 tasks
The MergeJSONFields was adding the parsed @timestamp key to the fields, instead of modifying it into the Event structure. This change makes it return the new timestamp (or the empty Timestamp if no change required), and the caller sets it into the event.
tsg
force-pushed
the
fix_double_timestamp_key
branch
from
c2a24b5
to
6386f6f
Compare
urso
approved these changes
Oct 25, 2017
|
@tsg thank you for the fast fix! 👍 |
tsg
added a commit
to tsg/beats
that referenced
this pull request
Oct 25, 2017
The MergeJSONFields was adding the parsed @timestamp key to the fields, instead of modifying it into the Event structure. This change makes it return the new timestamp (or the empty Timestamp if no change required), and the caller sets it into the event. (cherry picked from commit fa0cfc5)
monicasarbu
pushed a commit
that referenced
this pull request
Oct 26, 2017
The MergeJSONFields was adding the parsed @timestamp key to the fields, instead of modifying it into the Event structure. This change makes it return the new timestamp (or the empty Timestamp if no change required), and the caller sets it into the event. (cherry picked from commit fa0cfc5)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
The MergeJSONFields was adding the parsed @timestamp key to the fields, instead of modifying it into the Event structure. This change makes it return the new timestamp (or the empty Timestamp if no change required), and the caller sets it into the event.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MergeJSONFields was adding the parsed @timestamp key to the fields,
instead of modifying it into the Event structure. This change makes it
return the new timestamp (or the empty Timestamp if no change required),
and the caller sets it into the event.