Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic if event is dropped by queue #5532

Merged
merged 1 commit into from
Nov 7, 2017
Merged

Fix panic if event is dropped by queue #5532

merged 1 commit into from
Nov 7, 2017

Conversation

urso
Copy link

@urso urso commented Nov 7, 2017

Resolves: #5524

  • Only increase event seq-no if event has been pushed
  • Fix invalid ACK list if empty list is given to concat
  • Only execute ack handlers if number of events being ACKed > 0
  • Add missing debug log when collecting first ACK in ACK list

@urso urso added blocker needs_backport PR is waiting to be backported to other branches. review v6.0.0-GA labels Nov 7, 2017
Fix panic if event is dropped by queue
ebbe9a0 
- Only increase event seq-no if event has been pushed
- Fix invalid ACK list if empty list is given to concat
- Only execute ack handlers if number of events being ACKed > 0
- Add missing debug log when collecting first ACK in ACK list
@urso urso force-pushed the fix/seq-no-holes-on-drop branch from a7abe86 to ebbe9a0 Compare November 7, 2017 18:33
tsg
tsg approved these changes Nov 7, 2017
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFG

@tsg tsg merged commit 470b3d3 into elastic:6.0 Nov 7, 2017
tsg pushed a commit to tsg/beats that referenced this pull request Nov 7, 2017
@tsg
Fix panic if event is dropped by queue (elastic#5532)
536e161 
- Only increase event seq-no if event has been pushed
- Fix invalid ACK list if empty list is given to concat
- Only execute ack handlers if number of events being ACKed > 0
- Add missing debug log when collecting first ACK in ACK list

(cherry picked from commit 470b3d3)
@tsg tsg mentioned this pull request Nov 7, 2017
Merged
@tsg tsg removed the needs_backport PR is waiting to be backported to other branches. label Nov 7, 2017
ruflin pushed a commit that referenced this pull request Nov 8, 2017
@tsg @ruflin
Fix panic if event is dropped by queue (#5532) (#5536)
ee862c0 
- Only increase event seq-no if event has been pushed
- Fix invalid ACK list if empty list is given to concat
- Only execute ack handlers if number of events being ACKed > 0
- Add missing debug log when collecting first ACK in ACK list

(cherry picked from commit 470b3d3)
@urso urso deleted the fix/seq-no-holes-on-drop branch February 19, 2019 18:44
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@tsg
Fix panic if event is dropped by queue (elastic#5532)
68432ee 
- Only increase event seq-no if event has been pushed
- Fix invalid ACK list if empty list is given to concat
- Only execute ack handlers if number of events being ACKed > 0
- Add missing debug log when collecting first ACK in ACK list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
blocker review v6.0.0-GA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@urso @tsg