Dedot keys for jolokia metricsets #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 26, 2017
|
@ruflin This method should also apply |
ruflin
force-pushed
the
json-dedotting
branch
from
9b00fd5 to
3ebbb25
Compare
|
@andrewkroh Could you have a look at this one. It should be ready to go. |
andrewkroh
approved these changes
Jan 2, 2018
CHANGELOG.asciidoc
Outdated
| @@ -35,6 +35,7 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
| - Rename `heap_init` field to `heap.init`. {pull}5320[5320] | |||
| - Rename `http.response.status_code` field to `http.response.code`. {pull}5521[5521] | |||
| - Rename `golang.heap.system.optained` field to `golang.heap.system.obtained`. {issue}5703[5703] | |||
| - De dot keys in jolokia/jmx metricset to prevent collisions. | |||
There was a problem hiding this comment.
Can you please add the PR number.
andrewkroh
reviewed
Jan 2, 2018
CHANGELOG.asciidoc
Outdated
| @@ -37,6 +37,7 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
| - Rename `http.response.status_code` field to `http.response.code`. {pull}5521[5521] | |||
| - Rename `golang.heap.system.optained` field to `golang.heap.system.obtained`. {issue}5703[5703] | |||
| - Support haproxy stats gathering using http (additionaly to tcp socket). {pull}5819[5819] | |||
| - De dot keys in jolokia/jmx metricset to prevent collisions. | |||
There was a problem hiding this comment.
Added and rebased PR.
This should prevent name collisions and allow filtering on these fields. The feature is enabled by default and cannot be disable as otherwise ingestion could stop as Elasticsearch is returning an error. Currently not config option is provided as this should not be disabled. * Introduces DeDot function in common package * Adds tests to jmx for new functionality * Use new function also for docker labels Related to elastic#5942 Closes elastic#5916
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should prevent name collisions and allow filtering on these fields. The feature is enabled by default and cannot be disable as otherwise ingestion could stop as Elasticsearch is returning an error. Currently not config option is provided as this should not be disabled.
Related to #5942
Closes #5916