Rename file integrity fields #5995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
approved these changes
Jan 5, 2018
CHANGELOG.asciidoc
Outdated
| @@ -26,6 +26,7 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
| - Split the audit.kernel and audit.file metricsets into their own modules | |||
| named auditd and file_integrity, respectively. This change requires | |||
| existing users to update their config. {issue}5422[5422] | |||
| - Renamed file_integrity module fields. | |||
| @@ -2144,91 +2144,89 @@ Image labels. | |||
| These are the fields generated by the file_integrity module. | |||
|
|
|||
|
|
|||
| [float] | |||
| === `event.action` | |||
There was a problem hiding this comment.
Interesting field, we should discuss this more.
| @@ -21,7 +21,7 @@ const ( | |||
| bucketName = "file.v1" | |||
|
|
|||
| // Use old namespace for data until we do some field renaming for GA. | |||
| namespace = "audit.file" | |||
| namespace = "." | |||
There was a problem hiding this comment.
I assume that means it ignores the namespace?
| switch e.Namespace { | ||
| case ".": | ||
| // Add fields to root. | ||
| b.Fields.DeepUpdate(e.MetricSetFields) |
|
@andrewkroh I think this PR needs a make fmt |
This creates three groups of fields in the file integrity module `event`, `hash`, and `file`. It also changes `dataset.module` to `event.module` for all modules. elastic#5423
andrewkroh
force-pushed
the
feature/auditbeat-fim-ecs-rename
branch
from
27573bd to
0fa17bd
Compare
|
Updated the CHANGELOG and fmt'ed Metricbeat. |
file.mode and file.gid aren't populated for Windows.
ruflin
approved these changes
Jan 9, 2018
| - name: path | ||
| type: text | ||
| description: The path to the file. | ||
| multi_fields: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates three groups of fields in the file integrity module
event,hash, andfile.It also changes
dataset.moduletoevent.modulefor all modules.See data.json files for sample events.