-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a parameter to docker
prospector to filter on stream
#6057
Conversation
Sometimes you are only interested on stdout or stderr, this parameters allows to filter the input and only read one of them.
de2b159
to
e21a021
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a CHANGELOG entry?
return &DockerJSON{reader: r} | ||
func NewDockerJSON(r Reader, stream string) *DockerJSON { | ||
return &DockerJSON{ | ||
stream: stream, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should validate that it's a valid stream name.
@@ -85,7 +85,7 @@ type config struct { | |||
JSON *reader.JSONConfig `config:"json"` | |||
|
|||
// Hidden on purpose, used by the docker prospector: | |||
DockerJSON bool `config:"docker-json"` | |||
DockerJSON string `config:"docker-json"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm using the internal parameter to enable docker parsing and pass the desired stream through it, possible values:
""
- default, docker parsing is disabledall
- default fordocker
prospector, read all streamsstdout
stderr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, didn't realise you passed through the stream param.
Thank you for the review @ruflin, this should be ready for a second look 😄 |
Sometimes you are only interested on stdout or stderr, this parameters
allows to filter the input and only read one of them: