Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #6279 to 6.1: Metricbeat, include the logstash port in the metricbeat configuration #6287

Merged
merged 1 commit into from
Feb 10, 2018

Conversation

ph
Copy link
Contributor

@ph ph commented Feb 5, 2018

Cherry-pick of PR #6279 to 6.1 branch. Original message:

The YAML for the Logstash module did not include the port, this was
making the module unable to retrieve stats from the logstash host.

Fixes: #6274

@@ -67,6 +67,14 @@ https://github.com/elastic/beats/compare/v6.1.3...6.1[Check the HEAD diff]
*Heartbeat*

*Metricbeat*
- Rename `heap_init` field to `heap.init`. {pull}5320[5320]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ph I don't think that part of the change is intentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not its not, I am trying to understand what I did wrong with the cherrypick_pr tools, I mean I should have double checked it. But with a simple change I would have expected not to mess up with the history. I am confused.

@ph ph force-pushed the backport_6279_6.1 branch from ecaecf1 to 6ed0691 Compare February 7, 2018 14:49
@ph
Copy link
Contributor Author

ph commented Feb 7, 2018

updated

@ph
Copy link
Contributor Author

ph commented Feb 7, 2018

@ruflin I have created this #6312, to help with that :)

…#6279)

The YAML for the Logstash module did not include the port, this was
making the module unable to retrieve stats from the logstash host.

Fixes: #6274
(cherry picked from commit fce12c1)
@ph ph force-pushed the backport_6279_6.1 branch from 6ed0691 to b71e1b9 Compare February 9, 2018 02:16
@ruflin ruflin merged commit 4f246bd into elastic:6.1 Feb 10, 2018
@ruflin
Copy link
Collaborator

ruflin commented Feb 10, 2018

@ph I merged this now to get the change in. But I wonder if it is on purpose that there is now no changelog?

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…elastic#6279) (elastic#6287)

The YAML for the Logstash module did not include the port, this was
making the module unable to retrieve stats from the logstash host.

Fixes: elastic#6274
(cherry picked from commit d805f94)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants