Prevent to start filebeat when STDIN is used with other inputs #6463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ph
commented
Feb 23, 2018
ph
commented
- breaking changes: Stdin will now requires exclusive mode to run.
- Added helpers on top of the config class to retrieve enabled plugins.
- Refactored the stdin python integration testing into their own file.
- Added tests to check the combination of STDIN with other plugins
- Loop once on the enabled inputs
ph
force-pushed
the
fix/stdin-as-single-input
branch
from
8dd3362
to
6597fe9
Compare
|
Due to the nature of stdin related to EOF, it more appropriate to make sure the Stdin input is run in exclusive mode. |
ruflin
approved these changes
Feb 26, 2018
CHANGELOG.asciidoc
Outdated
| @@ -47,6 +47,8 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
| - Refactor the usage of prospector to input in the YAML reference and | |||
| the system test. {pull}6121[6121] | |||
| - Add IIS module to parse access log and error log. {pull}6127[6127] | |||
| - Add validation for Stdin, when Filebeat is configured with Stdin and any other inputs, Filebeat | |||
There was a problem hiding this comment.
I wonder if this is a bug fix or a breaking change :-)
|
@ph We should add a note about this also to the docs. |
|
@ruflin I need to take a look at config reload, maybe we should do some logic to prevent it there too can be a separate PR. |
ph
force-pushed
the
fix/stdin-as-single-input
branch
from
2a60992
to
4c89a4b
Compare
|
I have added a note to the documentation. @tsg could you take a look? |
ruflin
reviewed
Mar 27, 2018
filebeat/config/config_test.go
Outdated
| {name: "input exists and enabled", input: "stdin", expected: true, config: config}, | ||
| {name: "input exists and disabled", input: "udp", expected: false, config: config}, | ||
| {name: "input doesn't exist", input: "redis", expected: false, config: config}, | ||
| {name: "not inputs are enabled", input: "redis", expected: false, config: &Config{}}, |
| @@ -9,6 +9,8 @@ | |||
|
|
|||
| Use the `stdin` input to read events from standard in. | |||
|
|
|||
| Note: This input cannot be run at the same time of other inputs type. | |||
There was a problem hiding this comment.
at the same time "with" other input types? (plural types, singluar input?)
ph
force-pushed
the
fix/stdin-as-single-input
branch
from
4c89a4b
to
9d7dd34
Compare
- **breaking changes:** Stdin will now requires exclusive mode to run. - Added helpers on top of the config class to retrieve enabled plugins. - Refactored the stdin python integration testing into their own file. - Added tests to check the combination of STDIN with other plugins - Loop once on the enabled inputs
ph
force-pushed
the
fix/stdin-as-single-input
branch
from
9d7dd34
to
327d202
Compare
|
@ruflin typos fixed, rebased with master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.