Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS Policy to system metricbeat #6656

Merged
merged 1 commit into from
Apr 9, 2018
Merged

Add DNS Policy to system metricbeat #6656

merged 1 commit into from
Apr 9, 2018

Conversation

f0
Copy link
Contributor

@f0 f0 commented Mar 25, 2018 •
edited
Loading

Without dnsPolicy: ClusterFirstWithHostNet metricbeat cannot connect to an in cluster elasticseach via in cluster dns name e.g elasticsearch.default.svc because with HostNetwork: true the host resolve.conf is used

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ruflin ruflin added module Metricbeat Metricbeat containers Related to containers use case labels Mar 26, 2018
@ruflin ruflin requested a review from exekias March 26, 2018 08:31
@ruflin
Copy link
Contributor

ruflin commented Apr 5, 2018

@f0 Thanks for the contribution. I would like to have @jsoriano or @exekias to have a look at this change.

jsoriano
jsoriano reviewed Apr 6, 2018
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@f0 thanks for this, it LGTM, could you also add the dnsPolicy to deploy/kubernetes/metricbeat/metricbeat-daemonset.yaml?

@ruflin
Copy link
Contributor

ruflin commented Apr 6, 2018

I assume we will also need a changelog here.

@f0
Copy link
Contributor Author

f0 commented Apr 6, 2018

@ruflin Changelog done
@jsoriano done

jsoriano
jsoriano approved these changes Apr 6, 2018
View reviewed changes
CHANGELOG.asciidoc Outdated
@@ -59,7 +59,7 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di
- Made the url field of heartbeat aggregatable. {pull}6263[6263]

*Metricbeat*

- Add DNS Policy to system metricbeat. {pull}6656[6656]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify in the changelog that it refers to Kubernetes deployment files? For the rest it LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

exekias
exekias approved these changes Apr 9, 2018
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the changelog seems to include other lines that are unrelated to this change, could you review that?

@f0
Copy link
Contributor Author

f0 commented Apr 9, 2018

@exekias fixed. sorry

@jsoriano jsoriano merged commit 7424ad5 into elastic:master Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

@jsoriano jsoriano jsoriano approved these changes

Assignees
No one assigned
Labels
containers Related to containers use case Metricbeat Metricbeat module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@f0 @elasticmachine @ruflin @jsoriano @exekias