Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes deployment: Add ServiceAccount config to system metricbeat. #6824

Merged
merged 1 commit into from
Apr 12, 2018
Merged

Conversation

f0
Copy link
Contributor

@f0 f0 commented Apr 11, 2018

Without the SA, metricbeat is unable to get e.g event infos from kube-state-metrics

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@jsoriano jsoriano added module review Metricbeat Metricbeat containers Related to containers use case labels Apr 11, 2018
@ruflin ruflin requested a review from exekias April 11, 2018 11:55
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting this! could you use update metricbeat/metricbeat-deployment.yaml?

@f0
Copy link
Contributor Author

f0 commented Apr 11, 2018

@exekias done

@exekias
Copy link
Contributor

exekias commented Apr 11, 2018

ok to test

@exekias exekias merged commit 90f0c5a into elastic:master Apr 12, 2018
@exekias
Copy link
Contributor

exekias commented Apr 12, 2018

Thank you for taking this! 🎉

@exekias exekias added needs_backport PR is waiting to be backported to other branches. v6.2.4 labels Apr 20, 2018
exekias pushed a commit to exekias/beats that referenced this pull request Apr 23, 2018
ruflin pushed a commit that referenced this pull request Apr 26, 2018
…onfig to system metricbeat. (#6920)

Cherry-pick of PR #6824 to 6.2 branch. Original message: 

Without the SA, metricbeat is unable to get e.g event infos from kube-state-metrics
@ruflin ruflin removed the needs_backport PR is waiting to be backported to other branches. label Jun 14, 2018
@ruflin
Copy link
Contributor

ruflin commented Jun 14, 2018

@exekias Removed the backport label here as it was already backported to 6.2. Does it also need backporting to 6.3?

@exekias
Copy link
Contributor

exekias commented Jun 14, 2018

thanks @ruflin , no need for 6.3 backport, this change is there already

leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…count config to system metricbeat. (elastic#6920)

Cherry-pick of PR elastic#6824 to 6.2 branch. Original message: 

Without the SA, metricbeat is unable to get e.g event infos from kube-state-metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case Metricbeat Metricbeat module review v6.2.4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants