Harden file integrity flaky test #6907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need |
adriansr
force-pushed
the
fix/auditbeat/6864_flaky_test
branch
from
637cf0b to
cbd6def
Compare
|
jenkins, test this |
|
It failed under Windows, will have to test it more |
The file integrity system test depends on auditbeat's file output to validate functionality. This output is sometimes too slow and causes random CI failures. This patch makes sure that all the required events are written to the file output before stopping auditbeat.
adriansr
force-pushed
the
fix/auditbeat/6864_flaky_test
branch
from
cbd6def to
9ba140a
Compare
|
@ruflin it can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file integrity system test depends on auditbeat's file output to validate functionality. This output is sometimes too slow and causes random CI failures.
This patch makes sure that all the required events are written to the file output before stopping auditbeat.
I'm leaving this here so it can be merged if we see any flakiness in the file_integrity test. I saw the original test fail under Linux when run enough times in a loop, always with
Dir '{0}' not found.Related to #6893