Add dissect to traefik/access metricset for first stage of processing #7209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
in progress
ruflin
force-pushed
the
traefik-dissect
branch
2 times, most recently
from
28c2bd3
to
e633b6a
Compare
ph
reviewed
May 30, 2018
| "field": "traefik.access.message", | ||
| "patterns": [ | ||
| "\"%{WORD:traefik.access.method} %{DATA:traefik.access.url} HTTP/%{NUMBER:traefik.access.http_version}\" %{NUMBER:traefik.access.response_code} (?:%{NUMBER:traefik.access.body_sent.bytes}|-)( \"%{DATA:traefik.access.referrer}\")?( \"%{DATA:traefik.access.agent}\")?(?:%{NUMBER:traefik.access.request_count}|-)?( \"%{DATA:traefik.access.frontend_name}\")?( \"%{DATA:traefik.access.backend_url}\")?" | ||
| ], |
There was a problem hiding this comment.
I think you cold extract that information too :
"\"%{WORD:traefik.access.method} %{DATA:traefik.access.url} HTTP/%{NUMBER:traefik.access.http_version}\" %{NUMBER:traefik.access.response_code}
There was a problem hiding this comment.
Done. The nicest part here is that it makes it even more readable.
ph
reviewed
May 31, 2018
| - dissect: | ||
| tokenizer: '%{traefik.access.remote_ip} - %{traefik.access.user_name} [%{traefik.access.time}] | ||
| "%{traefik.access.method} %{traefik.access.url} HTTP/%{traefik.access.http_version}" | ||
| %{traefik.access.response_code} %{traefik.access.message}' |
There was a problem hiding this comment.
@ruflin I think this is a good first step, after looking at the complete if dissect was support chaining of tokenizer we could probably extract everything with 2 dissect processor.
|
@ph Yes, this is mainly to showcase dissect and demo how grok and dissect can be combined and not meant to replace grok. Want me to rebase or squash or you do it directly? |
|
@ruflin even if its a refactor should we create a changelog entry to make it more visible? |
This should provide an example use case on how grok and dissect can be combined. The resulting outcome should be identical. The main difference is that now some of the fields can be used on the Beats side for filtering out events.
|
Changelog added for visibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should provide an example use case on how grok and dissect can be combined. The resulting outcome should be identical. The main difference is that now some of the fields can be used on the Beats side for filtering out events.