-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
permit index-pattern only setup #7285
Conversation
with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws "Error importing Kibana dashboards: fail to import the dashboards in Kibana"
@graphaelli Any chance you could add a system test for this? There are a few tests for dashboard loading where we could add this. As this sounds like a bug fix, worth a changelog entry? |
9c6e1f8
to
c005619
Compare
|
||
beat.check_wait(exit_code=0) | ||
|
||
assert self.log_contains("Kibana dashboards successfully loaded") is True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we have a log message which reads more like index pattern successfully loaded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree it's confusing that the loading index patterns and dashboard are conflated but I think it would be best to tackle that as an enhancement rather than in this bugfix, that I'm hoping we can backport to 6.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, agree. I added the needs_backport
label. Could you open a follow up PR with the change mentioned above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do, thanks @ruflin
with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws "Error importing Kibana dashboards: fail to import the dashboards in Kibana" (cherry picked from commit ee0dc3e)
with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws "Error importing Kibana dashboards: fail to import the dashboards in Kibana" (cherry picked from commit 4d678b4)
with
setup.dashboards.enabled=true
,setup.dashboards.only_index=true
always throws"Error importing Kibana dashboards: fail to import the dashboards in Kibana"