Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permit index-pattern only setup #7285

Merged
merged 2 commits into from
Jun 11, 2018

Conversation

graphaelli
Copy link
Member

with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws
"Error importing Kibana dashboards: fail to import the dashboards in Kibana"

with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws
"Error importing Kibana dashboards: fail to import the dashboards in Kibana"
@ruflin
Copy link
Contributor

ruflin commented Jun 7, 2018

@graphaelli Any chance you could add a system test for this? There are a few tests for dashboard loading where we could add this.

As this sounds like a bug fix, worth a changelog entry?

@graphaelli graphaelli force-pushed the import-only-index-pattern branch from 9c6e1f8 to c005619 Compare June 7, 2018 19:37

beat.check_wait(exit_code=0)

assert self.log_contains("Kibana dashboards successfully loaded") is True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we have a log message which reads more like index pattern successfully loaded?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it's confusing that the loading index patterns and dashboard are conflated but I think it would be best to tackle that as an enhancement rather than in this bugfix, that I'm hoping we can backport to 6.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, agree. I added the needs_backport label. Could you open a follow up PR with the change mentioned above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, thanks @ruflin

@ruflin ruflin added the needs_backport PR is waiting to be backported to other branches. label Jun 11, 2018
@ruflin ruflin merged commit ee0dc3e into elastic:master Jun 11, 2018
@graphaelli graphaelli deleted the import-only-index-pattern branch June 11, 2018 12:48
@ruflin ruflin added v6.3.1 and removed needs_backport PR is waiting to be backported to other branches. labels Jun 14, 2018
ruflin pushed a commit to ruflin/beats that referenced this pull request Jun 18, 2018
with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws
"Error importing Kibana dashboards: fail to import the dashboards in Kibana"

(cherry picked from commit ee0dc3e)
ph pushed a commit that referenced this pull request Jun 18, 2018
with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws
"Error importing Kibana dashboards: fail to import the dashboards in Kibana"

(cherry picked from commit ee0dc3e)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
with setup.dashboards.enabled=true, setup.dashboards.only_index=true always throws
"Error importing Kibana dashboards: fail to import the dashboards in Kibana"

(cherry picked from commit 4d678b4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants