Add additional types to kubernetes metadata #7457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
houndci-bot
reviewed
Jun 28, 2018
libbeat/common/kubernetes/types.go
Outdated
|
|
||
| // Container data | ||
| type Container = v1.Container | ||
| type ContainerPort = v1.ContainerPort |
There was a problem hiding this comment.
exported type ContainerPort should have comment or be unexported
libbeat/common/kubernetes/types.go
Outdated
| // Pod data | ||
| type Pod = v1.Pod | ||
| type PodSpec = v1.PodSpec | ||
| type PodStatus = v1.PodStatus |
There was a problem hiding this comment.
exported type PodStatus should have comment or be unexported
libbeat/common/kubernetes/types.go
Outdated
| // Pod data | ||
| type Pod = v1.Pod | ||
| type PodSpec = v1.PodSpec |
There was a problem hiding this comment.
exported type PodSpec should have comment or be unexported
libbeat/common/kubernetes/types.go
Outdated
| @@ -34,11 +34,16 @@ func init() { | |||
| // Resource data | |||
| type Resource = k8s.Resource | |||
|
|
|||
| type ObjectMeta = metav1.ObjectMeta | |||
There was a problem hiding this comment.
exported type ObjectMeta should have comment or be unexported
vjsamuel
force-pushed
the
add_types_kubernetes_metadata
branch
2 times, most recently
from
a755aa6 to
b1784e4
Compare
exekias
approved these changes
Jun 28, 2018
vjsamuel
force-pushed
the
add_types_kubernetes_metadata
branch
from
b1784e4 to
c94880e
Compare
|
@exekias done. |
|
ok to test |
exekias
approved these changes
Jun 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lack of the below type definitions is impacting testing custom indexers that are loaded in as go-plugins. It would be nice to have them defined as well.