Filebeat: Add option to convert kafka module timezones to UTC #7578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
enhancement
in progress
jsoriano
force-pushed
the
filebeat-kafka-timezone
branch
2 times, most recently
from
3478d4c to
6d33214
Compare
ruflin
approved these changes
Jul 13, 2018
| default: false | ||
| # if ES < 6.1.0, this flag switches to false automatically when evaluating the | ||
| # pipeline | ||
| min_elasticsearch_version: |
There was a problem hiding this comment.
I completely forgot we have this feature. Nice.
There was a problem hiding this comment.
I copied this part from the system module 😄
jsoriano
force-pushed
the
filebeat-kafka-timezone
branch
from
6d33214 to
4238480
Compare
jsoriano
added
review
and removed
in progress
|
Rebased |
ycombinator
reviewed
Aug 17, 2018
| @@ -216,6 +216,7 @@ https://github.com/elastic/beats/compare/v6.2.3...master[Check the HEAD diff] | |||
| - Add Audit log fileset to the Elasticsearch module. {pull}7365[7365] | |||
| - Add Slow log fileset to the Elasticsearch module. {pull}7473[7473] | |||
| - Add deprecation fileset to the Elasticsearch module. {pull}7474[7474] | |||
| - Add `config_timezone` option to Kafka module to convert dates to UTC. {issue}7546[7546] {pull}7578[7578] | |||
There was a problem hiding this comment.
@jsoriano I think this line should say convert_timezone, not config_timezone, correct?
There was a problem hiding this comment.
Correct, I'll open a PR to fix this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7546