Update compatibility statement in Kafka docs #7639
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dedemorton
added
the
needs_backport
TBH, the same goes for kafka 0.8.2 and any other version ut 1.0.0. For testing we somewhat rely on saram testing. Docs and API states 0.8.2 is still "somewhat supported". But checking their travis CI, only 0.11 upwards are tested: https://travis-ci.org/Shopify/sarama |
urso
approved these changes
Jul 19, 2018
urso
approved these changes
Jul 19, 2018
|
Closing because a conflicting PR was merged that contains similar changes: #7665 |
dedemorton
removed
the
needs_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@urso Should this say, "This output works with Kafka 0.8.2.0 through 1.1.0" (instead of 1.0.0). It wasn't clear to me whether we are saying that we support (and have tested) against 1.1.0. I think it looks a little weird to have 1.1.0 as a valid setting if we don't test against it. WDYT?
Closes #6215