Backport to 6.x: Multiple doc changes (#7696 #7883 #7888 #7889 #7903 #7937 #7939 #7948 #7949 #7950) #8188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add docs about append_fields * Remove experimental tag from setup.template.json.enabled description
* Metricbeat: Add compatibility notes where missing, based on integration tests * Added review suggestions
{ needs escaping as otherwise asciidoc will show an empty code block.
* Add document for beat export dashboard Follow up from elastic#7239 * move to command reference * address review comments * review comments applied * apply review feedback
I've been told that using "golang" instead of "Go" is considered a faux pas in some circles. :-) I've replaced instances in the external docs, but I did not update the changelog, readmes, or code files.
|
@jsoriano For this PR, running |
|
Ok, failures in test don't seem related now 😃 LGTM |
jsoriano
approved these changes
Sep 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #8011
Cherry-picks the following doc PRs into the 6.x branch. Note that running make update resulted in some updates I wasn't expecting. Need someone to confirm that they are good for 6.x. Don't seem related the changes in cherry-picked PRs.
#7696
#7883
#7888
#7889
#7903
#7937
#7939
#7948
#7949
#7950