Cherry-pick #8045 to 6.x: Support Kibana Spaces #8545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 3, 2018
| @@ -48,11 +49,14 @@ func makeURL(url, path string, params url.Values) string { | |||
| return strings.Join([]string{url, path, "?", params.Encode()}, "") | |||
| } | |||
|
|
|||
| func Export(client *http.Client, conn string, dashboard string, out string) error { | |||
| func Export(client *http.Client, conn string, spaceID string, dashboard string, out string) error { | |||
There was a problem hiding this comment.
exported function Export should have comment or be unexported
ycombinator
commented
Oct 3, 2018
ruflin
approved these changes
Oct 4, 2018
* Support Kibana Spaces via setup.kibana.space.id setting * Adding CHANGELOG entry * Add space-id option to export_dashboards script * Add integration tests for importing and exporting dashboards with space ID * Adding -space-id option for export_dashboards.go to documentation * Adding entry to dev CHANGELOG * Prefix space path with / * Create Kibana space before trying to use it * Make spaces tests conditional on version * Add semver to requirements.txt * Add kbn-xsrf header to POST request * Don't recreate space in second space test (cherry picked from commit 2a04e2c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8045 to 6.x branch. Original message:
Resolves #7942.
Kibana is implementing a new feature called Spaces, in which Kibana saved objects (such as dashboards) and advanced settings can be restricted to a user-defined namespace. Spaces are identified by a unique ID, e.g.
my-space. There is also a notion of a Default space which corresponds to how Kibana worked up until the Spaces feature was introduced.Beats have the ability to import dashboards into Kibana as well as export dashboards out of Kibana. With Spaces, dashboards may belong to a specific space. So Beats must learn to accept an optional Space ID and operate against it when importing or exporting dashboards. This PR teaches Beats to do just that.
Concretely, if a user wishes to import or export dashboards from a specific space, say with ID =
my-space, they must either:<beat>.ymland setsetup.kibana.space.id: my-space, or<beat> setupor<beat> export dashboardalong with the-E setup.kibana.space.id=my-spaceoption.Similarly, if a Beat developer wishes to export dashboards from a specific space, say with ID =
my-space, they must run: