-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable host
and cloud
metadata processors by default
#8596
Conversation
b703a99
to
b3197db
Compare
+1 on this change. What I wonder is what the effect on data size with this could be? |
@ruflin @exekias I know the add_host_metadata processor causes issues on Windows 2003 and 32-bit 2008 SP2 servers. When enabled, the Beats agent doesn't start. If I understand correctly this PR will enable the add_host_metadata processor by default? How will this PR work out on Windows 2003 and 32-bit 2008 SP2 servers? |
Hmm, seems that since 6.4.x Beats are no longer supported on Windows 2003 servers.. (tried updating today, the Beats services keep stopping..). Imho this really is a pity, as we have several 2003 servers left that are impossible to update due to all kinds of reasons (on which I have no control).... |
hi @willemdh, this change only affects default configuration, you can always disable the processor if you don't really want it |
@willemdh I don't recall seeing any other bug reports for this. It would be good if you could open an issue for this an attach logs. Perhaps its something we can fix. |
I've run Metricbeat both with and without
The results are looking promising, WDYT? |
@exekias Agree, very promising. Seems like compression works well on this one. |
InfraOps UI will leverage this info to provide better insights from the application, we decided to enable these by default as that should benefit most users.
b3197db
to
1fa5275
Compare
rebased with master, let me know if you want some more testing before going ahead |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now looking at the change again, it's not really that it's on my default. If someone doesn't have any processors configure, they are not enabled. It's only enabled if you use our short config. I'm wondering if we should also enable it on the code side by default? If we do that, the problem is that I think at the moment there is no such thing as add_host_metata.enabled: false
that a user could use.
Yes, for now we are only talking about enabling it in the default configuration, with an easy way to opt out. Enabling them by code in a hardcoded way would be different, I would say we need to think more about that before moving that way. |
I wonder if we should modify the changelog to "enabled by default in the config" to make it more obvious. Someone upgrading and keep his config will not see any change. |
InfraOps UI will leverage this info to provide better insights from the application, we decided to enable these by default as that should benefit most users. (cherry picked from commit 9812157)
…rs by default (#8686) * Enable `host` and `cloud` metadata processors by default (#8596) InfraOps UI will leverage this info to provide better insights from the application, we decided to enable these by default as that should benefit most users. (cherry picked from commit 9812157) * Update CHANGELOG.asciidoc
InfraOps UI will leverage this info to provide better insights from the
application, we decided to enable these by default as that should
benefit most users.