Fix autopep8 checks by tying it to version 1.3.5 #8641
Conversation
| @@ -130,7 +130,7 @@ notice: python-env | |||
| .PHONY: python-env | |||
| python-env: | |||
| @test -d $(PYTHON_ENV) || virtualenv $(VIRTUALENV_PARAMS) $(PYTHON_ENV) | |||
| @$(PYTHON_ENV)/bin/pip install -q --upgrade pip autopep8 six | |||
| @$(PYTHON_ENV)/bin/pip install -q --upgrade pip autopep8==1.3.5 six | |||
There was a problem hiding this comment.
I think we should not upgrade autopep8 and six here. Also, not specify a version here.
We need to provide a requirements.txt and let pip install every dependency based on that file.
There was a problem hiding this comment.
We also upgrade pip in other places. I remember there is some historic reason for it. ++ on tying it to a specific version.
We don't have a global requirements.txt file yet. To get our builds back to green I suggest we get it in with this minimal change and follow up using requirements.txt file and not upgrading pip as it could be more effort then it seems.
There was a problem hiding this comment.
For the record: I am fine with upgrading pip. I am not fine with upgrading other packages e.g autopep8 here.
The newest autopep8 release breaks our checks.
ruflin
changed the title
ruflin
added
review
needs_backport
|
Created follow-up issue #8642 |
|
Merging as test failure is a flaky test. |
ruflin
added
v6.5.0
and removed
needs_backport
The newest autopep8 release breaks our checks.
The newest autopep8 release breaks our checks. (cherry picked from commit 1b6ef7d)
The newest autopep8 release breaks our checks.