-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not rely on an specific memcached version for autodiscover test #8656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here
exekias
added
review
Metricbeat
Metricbeat
flaky-test
Unstable or unreliable test cases.
needs_backport
PR is waiting to be backported to other branches.
labels
Oct 19, 2018
ruflin
approved these changes
Oct 19, 2018
@@ -25,7 +25,7 @@ def test_docker(self): | |||
'docker': { | |||
'templates': ''' | |||
- condition: | |||
equals.docker.container.image: memcached:1.5.3 | |||
equals.docker.container.image: memcached:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm torn here. In general I prefer that we use fixed versions for consistency but it seem for the autodiscovery test the content does not really matter.
exekias
added a commit
to exekias/beats
that referenced
this pull request
Oct 19, 2018
…lastic#8656) Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here (cherry picked from commit b2ba2ea)
exekias
added
v6.5.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Oct 19, 2018
exekias
added a commit
to exekias/beats
that referenced
this pull request
Oct 19, 2018
…lastic#8656) Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here (cherry picked from commit b2ba2ea)
exekias
added a commit
that referenced
this pull request
Oct 22, 2018
exekias
added a commit
that referenced
this pull request
Oct 22, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#8656) (elastic#8665) Old versions are sometimes removed, as this test is not about the module itself we can use the latest tag here (cherry picked from commit 1555a9c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue seen in travis:
Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here.