Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not rely on an specific memcached version for autodiscover test #8656

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Oct 19, 2018

Issue seen in travis:

======================================================================
ERROR: Test docker autodiscover starts modules from templates
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/go/src/github.com/elastic/beats/metricbeat/tests/system/test_autodiscover.py", line 40, in test_docker
    docker_client.images.pull('memcached:1.5.3')
  File "/usr/local/lib/python2.7/dist-packages/docker/models/images.py", line 415, in pull
    repository, tag, '@' if tag.startswith('sha256:') else ':'
  File "/usr/local/lib/python2.7/dist-packages/docker/models/images.py", line 295, in get
    return self.prepare_model(self.client.api.inspect_image(name))
  File "/usr/local/lib/python2.7/dist-packages/docker/utils/decorators.py", line 19, in wrapped
    return f(self, resource_id, *args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/docker/api/image.py", line 245, in inspect_image
    self._get(self._url("/images/{0}/json", image)), True
  File "/usr/local/lib/python2.7/dist-packages/docker/api/client.py", line 231, in _result
    self._raise_for_status(response)
  File "/usr/local/lib/python2.7/dist-packages/docker/api/client.py", line 227, in _raise_for_status
    raise create_api_error_from_http_exception(e)
  File "/usr/local/lib/python2.7/dist-packages/docker/errors.py", line 31, in create_api_error_from_http_exception
    raise cls(e, response=response, explanation=explanation)
ImageNotFound: 404 Client Error: Not Found ("no such image: memcached:1.5.3: No such image: memcached:1.5.3")

Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here.

Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here
@exekias exekias added review Metricbeat Metricbeat flaky-test Unstable or unreliable test cases. needs_backport PR is waiting to be backported to other branches. labels Oct 19, 2018
@@ -25,7 +25,7 @@ def test_docker(self):
'docker': {
'templates': '''
- condition:
equals.docker.container.image: memcached:1.5.3
equals.docker.container.image: memcached:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm torn here. In general I prefer that we use fixed versions for consistency but it seem for the autodiscovery test the content does not really matter.

@exekias exekias merged commit b2ba2ea into elastic:master Oct 19, 2018
exekias added a commit to exekias/beats that referenced this pull request Oct 19, 2018
…lastic#8656)

Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here

(cherry picked from commit b2ba2ea)
@exekias exekias added v6.5.0 and removed needs_backport PR is waiting to be backported to other branches. labels Oct 19, 2018
exekias added a commit to exekias/beats that referenced this pull request Oct 19, 2018
…lastic#8656)

Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here

(cherry picked from commit b2ba2ea)
@exekias exekias added the v6.4.3 label Oct 19, 2018
exekias added a commit that referenced this pull request Oct 22, 2018
…8656) (#8664)

Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here

(cherry picked from commit b2ba2ea)
exekias added a commit that referenced this pull request Oct 22, 2018
…8656) (#8665)

Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here

(cherry picked from commit b2ba2ea)
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…lastic#8656) (elastic#8665)

Old versions are sometimes removed, as this test is not about the module
itself we can use the latest tag here

(cherry picked from commit 1555a9c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Unstable or unreliable test cases. Metricbeat Metricbeat review v6.4.3 v6.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants