Cherry-pick #8646 to 6.4: Fix race in monitoring output #8659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The action part of the bulk request used to be a constant (used to use 'var' for init purposes only), but with 6.4 we have had to introduce the `index._type` field per monitoring type. With the introduction of telemetry we ended up with 2 publisher pipelines and 2 outputs, each with slightly different parameters, yet the action part has become a 'global' shared variable, that was modified by each reporter. If metrics and telemetry publish events at the same time, there is a race in modifying the global and serializing the bulk request. This change removes the global and creates an action item per event, such that there will be no sharing at all. (cherry picked from commit 1438000)
urso
force-pushed
the
backport_8646_6.4
branch
from
1f9bb30 to
efaa007
Compare
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…ic#8659) Cherry-pick of PR elastic#8646 to 6.4 branch. Original message: The action part of the bulk request used to be a constant (used to use 'var' for init purposes only), but with 6.4 we have had to introduce the `index._type` field per monitoring type. With the introduction of telemetry we ended up with 2 publisher pipelines and 2 outputs, each with slightly different parameters, yet the action part has become a 'global' shared variable, that was modified by each reporter. If metrics and telemetry publish events at the same time, there is a race in modifying the global and serializing the bulk request. This change removes the global and creates an action item per event, such that there will be no sharing at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8646 to 6.4 branch. Original message:
The action part of the bulk request used to be a constant (used to use
'var' for init purposes only), but with 6.4 we have had to introduce the
index._typefield per monitoring type.With the introduction of telemetry we ended up with 2 publisher
pipelines and 2 outputs, each with slightly different parameters, yet
the action part has become a 'global' shared variable, that was modified
by each reporter. If metrics and telemetry publish events at the same
time, there is a race in modifying the global and serializing the bulk
request.
This change removes the global and creates an action item per event,
such that there will be no sharing at all.