Cherry-pick #8653 to 6.4: Fix a race condition on add_host_metadata #8677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayden
reviewed
Oct 23, 2018
CHANGELOG.asciidoc
Outdated
| @@ -29,6 +29,21 @@ https://github.com/elastic/beats/compare/v6.4.1...6.4[Check the HEAD diff] | |||
|
|
|||
| *Affecting all Beats* | |||
|
|
|||
| - Fixed `add_host_metadata` not initializing correctly on Windows. {issue}7715[7715] | |||
There was a problem hiding this comment.
All this lines added. Is it correct?
There was a problem hiding this comment.
No, it is not correct :) thanks.
add_host_metadata keeps a cache of the host data collected, this cache is now updated atomically. (cherry picked from commit 74b9c6c)
jsoriano
force-pushed
the
backport_8653_6.4
branch
from
45354a8 to
de5bd2e
Compare
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
add_host_metadata keeps a cache of the host data collected, this cache is now updated atomically. (cherry picked from commit 6d25fd9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8653 to 6.4 branch. Original message:
Not sure if adding a mutex at this level will be too blocking for events processing, I have also though on other options to reduce contention on reads:
Continues with #8223