Cherry-pick #8621 to 6.x: Enhanced Heartbeat Telemetry #8719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add heartbeat telemetry. We now track: 1. The total number of active monitors 2. The total number of active monitors per protocol 3. The total number of checked endpoints per protocol 4. Counter versions of the above stats for the stats endpoint This also removes an accidentally comitted test case that tests nothing that broke with these refactors. (cherry picked from commit 596a0dd)
andrewkroh
approved these changes
Oct 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #8621 to 6.x branch. Original message:
Add heartbeat telemetry. We now track:
One note for reviewers, I changed the signature of the
createfunction used by heartbeat plugins to return the number ofendpoints for the given monitor.An alternate approach I considered was refactoring from the FP style for plugins to a more OO style where the stats could be pulled after creation by navigating a map of monitor objects. I considered this to be a more minimal change, but would welcome some feedback.