-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The 'export config' subcommand should display field reference instead of values #8769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
jenkins test this please |
1 similar comment
jenkins test this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible we should allow/prepare for multi-stage initialization of the beat configuration. The initialization of logging, paths, and keystore is already quite delicate.
libbeat/beat/config.go
Outdated
|
||
// ConfigOpts returns ucfg config options with a resolver linked to the current keystore. | ||
// TODO: Refactor to allow insert into the config option array without having to redefine everything | ||
func ConfigOpts(store keystore.Keystore) []ucfg.Option { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not have these in libbeat/beat
package. This package is supposed to be mostly stable providing some minimal common API for beats developers (No bc breaking changes if possible). Items with "TODO" + "Refactoring" should not land here.
Also, let's not leak the ucfg package. Libbeat is supposed to hide/wrap ucfg package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you propose to do to make sure we actually correctly initialize the resolvers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me take a look at that we pass to libbeat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rebase and waiting for CI. |
I've looked at the test suite, results and everything seems to be fine on all platforms minus windows. I think something is weird with this slave. I've logged into the windows slaves and saw the following:
|
jenkins test this please |
values Change the behavior of the export config to not display the values from the keystore or the environment.
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
… of values (elastic#8769) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 47c78ee)
…d display field reference instead of values (elastic#8832) Cherry-pick of PR elastic#8769 to 6.4 branch. Original message: Change the behavior of the export config to not display the values from the keystore or the environment.
… of values (elastic#8769) (elastic#8817) Change the behavior of the export config to not display the values from the keystore or the environment. (cherry picked from commit 53b688b)
Change the behavior of the export config to not display the values from
the keystore or the environment.