add_cloud_metadata asynchronous initialization #8845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that the add_cloud_metadata is enabled by default in all beats, we are losing 3 precious seconds every time a Beat is started outside a supported cloud environment. This patch makes the cloud detection an asynchronous task so the Beat can start and only block if initialisation is not completed at the time of the first enrichment. Running in debug mode bypasses this parallelism as the processor needs to be initialised when its String() method is called.
andrewkroh
reviewed
Oct 31, 2018
There was a problem hiding this comment.
SGTM 😄 . Needs a changelog.
Do you have any idea of what causes the full 3 sec timeout to be reached? IIRC it would fail quickly in the normal case because each request would result in a fast "no route to host" when connecting the link-local metadata IP address. Or perhaps we added new providers that connect to different addresses.
|
In my case it sits waiting on an ARP response for 169.254.169.254, which is used by most cloud providers as metadata service. Maybe a misconfiguration on my network? |
|
I'm not sure. But I see that the Tencent provider requires a DNS lookup so at any point it could be one of several causes so I think this is a great addition. |
|
Love the change Adrian I’ve run into same slowdown here
On Wed, Oct 31, 2018 at 8:09 PM Andrew Kroh ***@***.***> wrote:
I'm not sure. But I see that the Tencent provider requires a DNS lookup so
at any point it could be one of several causes so I think this is a great
addition.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#8845 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAACgJZ0yLxNhSyWuW0gtr3VyRGzkFUeks5uqjuigaJpZM4YEDW8>
.
--
ph
|
andrewkroh
approved these changes
Nov 2, 2018
|
jenkins, test this |
|
Any plans to backport this? 🙏 |
|
@andrewkroh @exekias care to have a final look at my last update? |
exekias
approved these changes
Nov 9, 2018
exekias
added
the
needs_backport
adriansr
added a commit
to adriansr/beats
that referenced
this pull request
Feb 1, 2019
Now that the add_cloud_metadata is enabled by default in all beats, we are losing 3 precious seconds every time a Beat is started outside a supported cloud environment. This patch makes the cloud detection an asynchronous task so the Beat can start and only block if initialization is not completed at the time of the first enrichment. Running in debug mode bypasses this parallelism as the processor needs to be initialized when its String() method is called. (cherry picked from commit 737a0b9)
adriansr
added
v6.7.0
and removed
needs_backport
adriansr
added a commit
that referenced
this pull request
Feb 4, 2019
Now that the add_cloud_metadata is enabled by default in all beats, we are losing 3 precious seconds every time a Beat is started outside a supported cloud environment. This patch makes the cloud detection an asynchronous task so the Beat can start and only block if initialization is not completed at the time of the first enrichment. Running in debug mode bypasses this parallelism as the processor needs to be initialized when its String() method is called. (cherry picked from commit 737a0b9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the add_cloud_metadata is enabled by default in all beats, we are losing 3 precious seconds every time a Beat is started outside a supported cloud environment.
This patch makes the cloud detection an asynchronous task so the Beat can start and only block if initialization is not completed at the time of the first enrichment.
Running in debug mode bypasses this parallelism as the processor needs to be initialized when its String() method is called.