Functionbeat use a concurrency of 5 by default for AWS lambda #8992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change the previous default of an unreserved concurrency, this allow to have a more sane value to keep the cost down and still allow people to turn the knob up to get better performance.
|
Lets get that merged after 6.5.0 |
ph
changed the title
ph
changed the title
|
jenkins test this please |
ph
changed the title
exekias
reviewed
Nov 12, 2018
| } | ||
|
|
||
| type lambdaConfig struct { | ||
| Concurrency int `config:"concurrency" validate:"positive"` | ||
| Concurrency int `config:"concurrency" validate:"min=0,max=1000"` |
There was a problem hiding this comment.
I'm wondering, is 1000 as hard maximum in AWS?
There was a problem hiding this comment.
It is indeed a weird setting, it is a hard limit per account of the total of running function of any kind.
IE: if you set this function to 5, It will run a maximum of 5 of your function.
|
Will need a changelog if merged after cut |
|
@exekias I have added a changelog, we don't want it for 6.5.0. |
exekias
approved these changes
Nov 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change the previous default of an unreserved concurrency, this
allow to have a more sane value to keep the cost down and still
allow people to turn the knob up to get better performance.