Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip and status to heartbeat dashboard table #9022

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Nov 9, 2018

The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

  1. A given monitor.id often runs against separate IPs which may have different downtime results
  2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes #8972

The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

1. A given monitor.id often runs against separate IPs which may have different downtime results
2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes elastic#8972
Copy link

@dov0211 dov0211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewvc
Copy link
Contributor Author

jenkins, retest this please

@andrewvc andrewvc added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Nov 26, 2018
@andrewvc andrewvc merged commit b3de5f6 into elastic:master Nov 26, 2018
andrewvc added a commit to andrewvc/beats that referenced this pull request Nov 26, 2018
The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

1. A given monitor.id often runs against separate IPs which may have different downtime results
2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes elastic#8972

(cherry picked from commit b3de5f6)
andrewvc added a commit that referenced this pull request Nov 27, 2018
The heartbeat dashboard table currently doesn't include these fields by default.
These fields are useful for two reasons:

1. A given monitor.id often runs against separate IPs which may have different downtime results
2. Viewing the latest status for a given id/status tuple is a common use case. It answers the question: "what's down?".

Fixes #8972

(cherry picked from commit b3de5f6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants