Propagate Sync error when running SafeFileRotate #9069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
approved these changes
Nov 14, 2018
ruflin
approved these changes
Nov 14, 2018
|
@ruflin Done. |
|
@kvch I have added the needs_backport, My understand is we want to use that to debug maybe an issue so I think we should port it to 6.x, 6.5. |
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 19, 2018
Previously, it was possible SafeFileRotate encountered an error without propagating it, because the return value of os.Sync was not utilized. From now on the errors from Sync are propagated. (cherry picked from commit 93eb92a)
kvch
added
v6.6.0
and removed
needs_backport
kvch
added a commit
to kvch/beats
that referenced
this pull request
Nov 19, 2018
Previously, it was possible SafeFileRotate encountered an error without propagating it, because the return value of os.Sync was not utilized. From now on the errors from Sync are propagated. (cherry picked from commit 93eb92a)
kvch
added a commit
that referenced
this pull request
Nov 21, 2018
…otate (#9142) * Propagate Sync error when running SafeFileRotate (#9069) Previously, it was possible SafeFileRotate encountered an error without propagating it, because the return value of os.Sync was not utilized. From now on the errors from Sync are propagated. (cherry picked from commit 93eb92a)
kvch
added a commit
that referenced
this pull request
Nov 22, 2018
…otate (#9141) * Propagate Sync error when running SafeFileRotate (#9069) Previously, it was possible SafeFileRotate encountered an error without propagating it, because the return value of os.Sync was not utilized. From now on the errors from Sync are propagated. (cherry picked from commit 93eb92a)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…feFileRotate (elastic#9142) * Propagate Sync error when running SafeFileRotate (elastic#9069) Previously, it was possible SafeFileRotate encountered an error without propagating it, because the return value of os.Sync was not utilized. From now on the errors from Sync are propagated. (cherry picked from commit 84bdbd9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it was possible
SafeFileRotateencountered an error without propagating it, because the return value ofos.Syncwas not utilized.From now on the errors from
Syncare propagated.