Move generator packages of Filebeat from scripts/generator to generator #9147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
added
in progress
houndci-bot
reviewed
Nov 19, 2018
|
I assume as soon as #9097 is merged, this Diff becomes much smaller? |
|
Yes. And it also needs a rebase. |
kvch
force-pushed
the
refactoring-move-generator-packages-from-scripts
branch
from
6d36ba5
to
bcaf493
Compare
kvch
force-pushed
the
refactoring-move-generator-packages-from-scripts
branch
from
bcaf493
to
07d7801
Compare
kvch
added
review
and removed
blocked
in progress
ph
approved these changes
Nov 30, 2018
kvch
changed the title
kvch
changed the title
|
Previously green. I only added a changelog entry. |
kvch
added a commit
that referenced
this pull request
Feb 8, 2019
This PR exposes the existing Filebeat module generators as `generate` subcommand. ``` $ ./filebeat generate -h Generate Filebeat modules, filesets and fields.yml Usage: filebeat generate [command] Available Commands: fields Generates a new fields.yml file for fileset fileset Generates a new fileset module Generates a new module ``` The subcommands `module`, `fileset` and `fields` use the same code as the scripts. I added E2E tests to validate the functionality. Blocked by #9147 as it contains the refactorings of that PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From now on generator functions are located under
generatorpackage.This PR is the reincarnation of #7506 It includes the refactoring requested previously.