Cherry-pick #9349 to 6.3: Fix a typo in the syslog parser to correctly parse December or Dec #9354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lastic#9349) The syslog parser was missing a `D` in the month, so it was failling to parse common syslog event from december, this PR add the missing letter and also add an unit test to cover both the short and full month format. (cherry picked from commit 37fc3a5)
urso
approved these changes
Dec 3, 2018
|
I think we are missing a PR in the 6.3 branch that vendor the pep8 version, I will track it down. |
|
Just to keep a trace the python test are failling on travis because we are not using a fix version of pep8 see #9379 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9349 to 6.3 branch. Original message:
The syslog parser was missing a
Din the month, so it was failling toparse common syslog event from december, this PR add the missing letter
and also add an unit test to cover both the short and full month format.
Fixes: #9323
Reported at https://discuss.elastic.co/t/typo-in-syslog-rfc3164-rl-causes-parsing-errors-for-december-syslog-dates/159030