Update migration file to new structure #9381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/infrastructure |
ruflin
force-pushed
the
migration-file-update
branch
from
160bda9 to
388e342
Compare
graphaelli
reviewed
Dec 4, 2018
dev-tools/ecs-migration.yml
Outdated
| @@ -6,44 +6,46 @@ | |||
| # | |||
| # - from: source-field-in-6.x | |||
| # to: target-filed-in-ECS | |||
| # # Alias field is useful for fields where there is a 1-1 mapping from old to new | |||
| # alias: true-if-alias-is-required-in-6x | |||
| # # Alias field is useful for fields where many-11 mapping from new to old are needed | |||
There was a problem hiding this comment.
I don't see that fix. Have you pushed? 😂
webmat
reviewed
Dec 4, 2018
webmat
reviewed
Dec 4, 2018
webmat
approved these changes
Dec 4, 2018
ruflin
commented
Dec 4, 2018
dev-tools/ecs-migration.yml
Outdated
| @@ -6,44 +6,46 @@ | |||
| # | |||
| # - from: source-field-in-6.x | |||
| # to: target-filed-in-ECS | |||
| # # Alias field is useful for fields where there is a 1-1 mapping from old to new | |||
| # alias: true-if-alias-is-required-in-6x | |||
| # # Alias field is useful for fields where many-11 mapping from new to old are needed | |||
|
Yeah I did read through quickly. Will pore through it one more time. |
The new structure makes it clear which alias have to happen in 6.x and which ones in 7.x
ruflin
force-pushed
the
migration-file-update
branch
from
388e342 to
782a491
Compare
webmat
reviewed
Dec 4, 2018
| alias: true | ||
| copy_to: false | ||
|
|
||
| - from: beat.hostname | ||
| to: agent.hostname |
There was a problem hiding this comment.
@MikePaquette is pushing back on agent.hostname, btw.
Agent should always be running on the host itself. If the monitoring agent is outside of the host, it should be represented in observer.hostname (used to be called device.hostname, but device is being renamed to observer).
There was a problem hiding this comment.
Should be addressed in another PR, though.
webmat
suggested changes
Dec 4, 2018
webmat
approved these changes
Dec 4, 2018
graphaelli
approved these changes
Dec 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new structure makes it clear which alias have to happen in 6.x and which ones in 7.x