Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #9417 to 6.5: Fix saved objects in filebeat haproxy dashboard #9465

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Cherry-pick #9417 to 6.5: Fix saved objects in filebeat haproxy dashboard #9465

merged 2 commits into from
Dec 12, 2018

Conversation

jsoriano
Copy link
Member

Cherry-pick of PR #9417 to 6.5 branch. Original message:

Fix issues with saved objects in filebeat dashboard:

  • Use proper field for client ip
  • Add the panels to the dashboard
  • Use same map configuration as in other modules for geoip view

Fixes #9389

@jsoriano
Fix saved objects in filebeat haproxy dashboard (elastic#9417)
1a6dfe8 
Use proper field for client ip
Add the panels to the dashboard
Use same map configuration as in other modules for geoip view

(cherry picked from commit cb898ff)
@ruflin ruflin requested a review from sayden December 10, 2018 15:15
sayden
sayden approved these changes Dec 10, 2018
View reviewed changes
Copy link
Contributor

@sayden sayden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just waiting until CI is green. I was wondering if it's ok that fields like heatClusterSize are now removed. I know I come late to ask this so feel free to ignore the question.. 😅

@jsoriano
Copy link
Member Author

jsoriano commented Dec 11, 2018 •
edited
Loading

I was wondering if it's ok that fields like heatClusterSize are now removed.

I hope so 😄 I copied the map configuration from the apache one to remove references to the tiles service.

If something happens to be broken because of this we'll fix it in a follow up PR as this is already merged in master.

@sayden
Copy link
Contributor

sayden commented Dec 11, 2018

Error seems a Mac OSX timeout

@jsoriano jsoriano merged commit 961bc1f into elastic:6.5 Dec 12, 2018
@jsoriano jsoriano deleted the backport_9417_6.5 branch December 12, 2018 18:25
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@jsoriano
Fix saved objects in filebeat haproxy dashboard (elastic#9417) (elast…
1cfec75 
…ic#9465)

Use proper field for client ip
Add the panels to the dashboard
Use same map configuration as in other modules for geoip view

(cherry picked from commit 8151470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayden sayden sayden approved these changes

Assignees
No one assigned
Labels
backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsoriano @sayden