Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] Change event.type to event.kind #9489

Merged
merged 3 commits into from
Dec 12, 2018

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Dec 11, 2018

To be compatible with ECS, this changes the event.type field to event.kind throughout the system module.

Since event.kind is not yet in fields.ecs.yml, system tests are modified to skip failures related to that. There is a follow-up issue to add it.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once tests go green.

Only one test seemed to fail, potentially due to a Docker hiccup. So I restarted it (libbeat testsuite).

I'm not a big fan of TODOs in code, but in this case I'm good with them

@cwurm cwurm merged commit a888e7f into elastic:feature-auditbeat-host Dec 12, 2018
@cwurm cwurm deleted the event_kind branch December 12, 2018 09:40
cwurm pushed a commit to cwurm/beats that referenced this pull request Dec 16, 2018
To be compatible with ECS, changes the `event.type` field to `event.kind` throughout the system module.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants