Add socket_summary to default system metricsets #9709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
enhancement
module
review
Metricbeat
|
We have to update gopsutil for shirou/gopsutil#549 before merging this. |
Add support for Windows now that it is supported by gopsutil and remove the experimental tag. Enable it by default.
jsoriano
force-pushed
the
socket-summary-ga
branch
from
ce0c636
to
97ba003
Compare
ruflin
approved these changes
Dec 21, 2018
|
Ok, I will backport it, gopsutil upgrade will have to be backported first. |
jsoriano
added
the
needs_backport
jsoriano
added
v6.7.0
and removed
needs_backport
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 21, 2018
Add support for Windows now that it is supported by gopsutil and remove the experimental tag. Enable it by default. (cherry picked from commit 1960943)
jsoriano
added a commit
that referenced
this pull request
Dec 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Windows now that it is supported by gopsutil and remove
the experimental tag. Enable it by default.
Windows support in gopsutil: shirou/gopsutil#549