Vsphere nil pointers access in Metricbeat module #9784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins, test this |
|
Fail seems unrelated. Awaiting for review |
ruflin
added
the
needs_backport
ruflin
reviewed
Dec 25, 2018
sayden
force-pushed
the
bugfix/mb/vsphere-nil-pointers
branch
from
1aebe7d
to
4dfefcd
Compare
ruflin
reviewed
Dec 27, 2018
ruflin
added
Team:Integrations
ruflin
reviewed
Dec 28, 2018
| }, | ||
| } | ||
|
|
||
| if hs.Summary.Hardware != nil { | ||
| totalCPU := int64(hs.Summary.Hardware.CpuMhz) * int64(hs.Summary.Hardware.NumCpuCores) | ||
| cpu["total"] = common.MapStr{ |
There was a problem hiding this comment.
What you can use as an alternative here is cpu.Put('total.mhz', totalCPU). It will have the same effect. Using this you could still generate the full event as you had previously on line 118 and then use:
event.Put('cpu.total.mhz', totalCPU)
The outcome of the code is exactly the same but it would make it shorter and hopefully more readable.
There was a problem hiding this comment.
Entries have been updated. I quick look will give me some calm brain cycles 😄
sayden
force-pushed
the
bugfix/mb/vsphere-nil-pointers
branch
from
1808197
to
72dbb2d
Compare
ruflin
approved these changes
Dec 28, 2018
sayden
added a commit
to sayden/beats
that referenced
this pull request
Dec 28, 2018
…elastic#9784) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit 7c31ced)
sayden
added
v6.7.0
and removed
needs_backport
sayden
added a commit
to sayden/beats
that referenced
this pull request
Dec 28, 2018
…elastic#9784) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit 7c31ced)
sayden
added a commit
to sayden/beats
that referenced
this pull request
Dec 28, 2018
…elastic#9784) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit 7c31ced)
sayden
added a commit
that referenced
this pull request
Dec 31, 2018
…#9784) (#9822) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit 7c31ced)
sayden
added a commit
that referenced
this pull request
Dec 31, 2018
…#9784) (#9823) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit 7c31ced)
sayden
added a commit
that referenced
this pull request
Dec 31, 2018
…#9784) (#9824) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit 7c31ced)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#9784) (elastic#9824) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit a05b14e)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…elastic#9784) (elastic#9823) In Vsphere module, some fields returned by the Vsphere library contain pointers to some values that could potentially be nil. With this PR, we do a nil-check prior every access to any of those fields to avoid their writing in case they are nil and protecting Metricbeat from panicking. (cherry picked from commit a05b14e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that some fields within the vsphere module on Metricbeat are pointers where the
nilcheck access is not being done. This can cause panics that are not easy to reproduce.This PR checks every pointer that acces a pointer from the
gvmomilibrary which is used to access vsphere data.Initially, we only know about panics in the
virtualmachinemetricset but I have seen that thehostmetricset could potentially have the same problem